Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: expose omnisharp/client/findReferences custom command for code lenses #1807

Conversation

razzmatazz
Copy link
Contributor

This exposes a custom omnisharp/client/findReferences command that is meant to be handled by LSP client to display references at given Location.

Since this is a custom command there needs to be changes made per-LSP client to handle this command, issue a textDocument/references request at given Location and display that on UI.

…command

This custom command is meant to be handled by LSP client to display
references on a given Location.
@razzmatazz
Copy link
Contributor Author

This PR is baseline for another PR that will come later that will expose custom commands to run tests via LSP too (via codelens and manually, from LSP UI).

@david-driscoll
Copy link
Member

sorry @razzmatazz I've been really focusing on the lsp library for the powershell folks. This looks awesome, thanks!

@david-driscoll david-driscoll merged commit 402cfbc into OmniSharp:master May 24, 2020
@razzmatazz
Copy link
Contributor Author

razzmatazz commented May 28, 2020

sorry @razzmatazz I've been really focusing on the lsp library for the powershell folks. This looks awesome, thanks!

No problem, and thanks for all the work! It seems to me like most of the work regarding LSP is already done, i'm just straightening some of the pipes so things work for me personally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants