Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include version matched target files with minimal MSBuild #1895

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Aug 18, 2020

Instead of including the .target files from the Mono on the build machine. Overwrit those .target files with the versions from the MSBuild Runtime. Also, use the non-deprecated compiler toolset package.

@JoeRobich
Copy link
Member Author

@david-driscoll @mholo65 @filipw ptal

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used to work... 😩

@filipw filipw merged commit 07c6898 into OmniSharp:master Aug 18, 2020
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants