Don't set completion text to full signature unless its override or partial method completion #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtial method completion
david-driscoll
approved these changes
May 18, 2017
| @@ -13,24 +12,36 @@ namespace OmniSharp.Roslyn.CSharp.Services.Intellisense | |||
| { | |||
| internal static class CompletionItemExtensions | |||
| { | |||
| private const string GetSymbolsAsync = "GetSymbolsAsync"; | |||
| private const string Provider = "Provider"; | ||
| private const string SymbolCompletionItem = "Microsoft.CodeAnalysis.Completion.Providers.SymbolCompletionItem"; | ||
| private const string SymbolCompletionProvider = "Microsoft.CodeAnalysis.CSharp.Completion.Providers.SymbolCompletionProvider"; | ||
| private const string SymbolKind = "SymbolKind"; |
|
Note: This isn't quite right. Some tests failing. |
|
thanks! I somehow missed it, sorry. However, it didn't occur for me before - for example this is what I see even before this PR was merged:
|
|
aaaaah mystery solved! I never saw this on the original PR because I tested against the version of C# for VS Code which had the magic completion Regex still present (which we remved here dotnet/vscode-csharp@01aa52e). Turns out the purpose of this was to collapse overloads together on the client side. It absolutely makes sense to do this on the server side correctly instead - thanks @DustinCampbell for fixing 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a regression where overloads would not be collapsed in the VS Code completion list. In addition, I added a couple of tweaks to ensure that we report the "EnumMember" and "Const" kinds.