Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UseUrls method #971

Merged
merged 2 commits into from
Oct 2, 2017
Merged

Added UseUrls method #971

merged 2 commits into from
Oct 2, 2017

Conversation

Brumawen
Copy link

@Brumawen Brumawen commented Oct 2, 2017

Configured Urls as per https://docs.microsoft.com/en-us/aspnet/core/fundamentals/hosting?tabs=aspnetcore2x

Fixed issue where the host URL was defaulting to 5000 regardless of the port number being passed in the parameters.

…undamentals/hosting?tabs=aspnetcore2x

Fixed issue where the host URL was defaulting to 5000 regardless of the port number being passed in the parameters.
@DustinCampbell
Copy link
Contributor

I fixed the xUnit issues that caused the CI to break on this PR.

Copy link
Contributor

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DustinCampbell
Copy link
Contributor

Thanks for the contribution @Brumawen!

@DustinCampbell DustinCampbell merged commit 23ae5f9 into OmniSharp:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants