Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Elementor XML - compsupp-7621 #403

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Updating Elementor XML - compsupp-7621 #403

merged 2 commits into from
Oct 17, 2024

Conversation

Kitilyes
Copy link
Contributor

dgwatkins
dgwatkins reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dgwatkins dgwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't contact-buttons-var-2 missing?

dgwatkins
dgwatkins reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dgwatkins dgwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was contact_tooltip removed intentionally @Kitilyes?

It seems to still be valid.

dgwatkins
dgwatkins reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dgwatkins dgwatkins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indenting is incorrect around line 527 @Kitilyes

@Kitilyes
Copy link
Contributor Author

Kitilyes commented Oct 17, 2024 •
edited
Loading

  • There is no contact-buttons-var-2 in Elementor source code
  • There are 12 different versions of this widget, contact-buttons-var-XX , contact_tooltip was part of a previously added widget contact-buttons-var-4 belongs to the same prooject, so it made sense to move this widget under contact-buttons-var-3 for better reading.
  • You are right, 527 and 528 have wrong indenting , do I do another commit? @dgwatkins

@dgwatkins
Copy link
Collaborator

Yes please @Kitilyes

@Kitilyes
[Create XML config for Elementor Floating Elements] Adding support fo…
816e27c 
…r new Elementor Float Elements

527 and 528 had wrong indenting - Corrected
@Kitilyes
Copy link
Contributor Author

Done @dgwatkins

dgwatkins
dgwatkins approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dgwatkins dgwatkins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Kitilyes

Is it ready to be merged and deployed?

@Kitilyes
Copy link
Contributor Author

Yes, it is ready.

@dgwatkins dgwatkins merged commit 39527d7 into OnTheGoSystems:master Oct 17, 2024
1 check passed
@dgwatkins
Copy link
Collaborator

merged and deployed, thanks @Kitilyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgwatkins dgwatkins dgwatkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kitilyes @dgwatkins