Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R23: GDAC rejects files with type SOLO_BGC #85

Closed
ClaudiaAOML opened this issue Mar 25, 2024 · 5 comments
Closed

R23: GDAC rejects files with type SOLO_BGC #85

ClaudiaAOML opened this issue Mar 25, 2024 · 5 comments
Assignees
Labels

Comments

@ClaudiaAOML
Copy link

ClaudiaAOML commented Mar 25, 2024

SOLO_BGC as instrument type gets rejected by the GDACs. Because of that we have to use SOLO_II. Not sure if I picked the right names as "assignees" ...

@tcarval
Copy link
Contributor

tcarval commented Mar 28, 2024

@ClaudiaAOML Hello Claudia, I'll check the content of AOML rejected metadata files and register on checker and NVS the new instrument type.

@tcarval
Copy link
Contributor

tcarval commented Mar 28, 2024

There are 5 metadata files that were rejected by the format checker
ls -lah *_meta.nc
-rw-r----- 1 co_exp coriolis 105K Mar 6 19:19 2903867_meta.nc
-rw-r----- 1 co_exp coriolis 111K Mar 20 03:45 4903748_meta.nc
-rw-r----- 1 co_exp coriolis 105K Mar 6 18:45 4903750_meta.nc
-rw-r--r-- 1 co_exp coriolis 35K Mar 21 22:34 5906949_meta.nc
-rw-r----- 1 co_exp coriolis 107K Mar 8 00:13 6990583_meta.nc

2903867_meta.nc, 4903748_meta.nc.filecheck, 4903750_meta.nc 6990583_meta.nc : replace MBARI by SBE
SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'

5906949_meta.nc : remove the empty LAUNCH_CONFIG_PARAMETER_NAME
LAUNCH_CONFIG_PARAMETER_NAME[27]: Incorrectly formed name ''
CONFIG_PARAMETER_NAME[15]: Incorrectly formed name ''

@tcarval
Copy link
Contributor

tcarval commented Mar 28, 2024

@ClaudiaAOML , is this R23 entry for SOLO_BGC correct ? Should we use MBARI in platform maker and description ?

<style> </style>
PLATFORM_TYPE PLATFORM_TYPE_KEY IXIXIX (1770) PLATFORM_MAKER Description FLOAT_SERIAL_NO SAMPLE
SOLO_BGC 206 884 885 886 887 MBARI MBARI SOLO  
SOLO_W 201 850 851 852 WHOI WHOI SOLO  
SOLO_II 202 853 879 SIO_IDG SIO SOLOII  
SOLO_D 220 862 SIO_IDG Deep SOLO  
SOLO_D_MRV 221 874 MRV    
SOLO 200 850 851 852 SIO_IDG SIO SOLO  

@tcarval
Copy link
Contributor

tcarval commented Mar 29, 2024

Add SOLO_BGC in R23 and add SIO_IDG as the platform maker.
SOLO_BGC | 206 | 884 885 886 887 | SIO_IDG | MBARI SOLO |

@ClaudiaAOML can you send me a sample file ?
It will not be possible to have SOLO_BGC with 2 makers (SIO_IDG or MRV).

tcarval added a commit to OneArgo/ArgoFormatChecker that referenced this issue Apr 12, 2024
@tcarval
Copy link
Contributor

tcarval commented Apr 12, 2024

@ClaudiaAOML hello Claudia, I published a new version of the file checker to accept SOLO_BGC float type with SIO_IDG maker.
https://github.com/euroargodev/ArgoNetCDF/releases/tag/v2.8.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants