Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Fullbleed IAMs #1481

Merged
merged 17 commits into from
Nov 12, 2021
Merged

Android Fullbleed IAMs #1481

merged 17 commits into from
Nov 12, 2021

Commits on Nov 9, 2021

  1. Make the IAM full screen 

    No Margin IAMs now are full screen covering the status bar.

This commit does not yet adjust the IAM content to account for this
    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    a134763 View commit details
    Browse the repository at this point in the history

  2. Setting safe area insets 

    Note that this doesn't override the App's display cutout window settings meaning that if the App doesn't support content bleeding under the cutout then the IAM will not go under the cutout.
    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    81acdd9 View commit details
    Browse the repository at this point in the history

  3. moving safeareainset script to webviewmanager

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    75823e5 View commit details
    Browse the repository at this point in the history

  4. using updateSafeAreaInsets

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    4f3ec83 View commit details
    Browse the repository at this point in the history

  5. only update insets if the IAM is fullscreen

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    3015c9a View commit details
    Browse the repository at this point in the history

  6. Updating SDK and demo app to use API 30 

    also testing fullscreen windowManager flags in the demo app
    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    b8fc929 View commit details
    Browse the repository at this point in the history

  7. Fixing full bleed carousel width

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    2728bb8 View commit details
    Browse the repository at this point in the history

  8. snapshot of working IAM under notch 

    Just a snapshot of it working, don't desinged to be merged.
Will create another branch to follow up with a commit of only
then changes needed.
    @jkasten2 @emawby
    jkasten2 authored and emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    1fe3dc7 View commit details
    Browse the repository at this point in the history

  9. Revert example app changes

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    68589b3 View commit details
    Browse the repository at this point in the history

  10. cleaning up InAppMessageView

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    fa4753a View commit details
    Browse the repository at this point in the history

  11. Fixing non-fullbleed IAMs by using type dialog instead of panel 

    Other cleanup as well
    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    9b6c06c View commit details
    Browse the repository at this point in the history

  12. Using immersize and hide navigation for fullbleed IAMs

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    fdc65b1 View commit details
    Browse the repository at this point in the history

  13. simplify logic for getCutoutandStatusBarInsets and use immersive mode

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    a926095 View commit details
    Browse the repository at this point in the history

  14. Fixing insets for non API 29 devices

    @emawby
    emawby committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    71f558c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Renaming isFullscreen to isFullbleed to avoid confusion

    @emawby
    emawby committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    f22dfe7 View commit details
    Browse the repository at this point in the history

  2. Running setSafeAreaInsets() on main thread 

    webView.evaluateJavascript methods should be run on the main thread
    @emawby
    emawby committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b53858c View commit details
    Browse the repository at this point in the history

  3. removing handleResize

    @emawby
    emawby committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    5b30875 View commit details
    Browse the repository at this point in the history