Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign release files instead of archive subset #1511

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jan 12, 2022

Description

One Line Summary

Fixes missing .asc signing files when uploading to Sonatype to ship a release to Maven Central.

Details

Motivation

Without this change Sonatype reject the release and you can't ship a release.

Scope

Only effects signing for releases.

Gradle Documentation

See Gradle's Maven Publish Plugin documentation and its complete example on how publishing.publications is used.

Testing

Manual testing

Tested this by uploading a release to Sonatype and confirmed it passes it's validation after closing and all .asc files exist. Also created a 4.6.4-rc1 release to ensure it works end-to-end with Maven Central.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Release Signing

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

This fixes an issue where sonatype rejects the release due to missing
.asc signing files.
@jkasten2 jkasten2 requested review from Jeasmine, emawby and a team January 12, 2022 19:08
@jkasten2
Copy link
Member Author

Tests failed due to one unrelated flaky test.

com.test.onesignal.GenerateNotificationRunner > shouldContainPayloadWhenOldSummaryNotificationIsOpened FAILED
    junit.framework.ComparisonFailure: expected:<UUID[2]> but was:<UUID[1]>
        at junit.framework.Assert.assertEquals(Assert.java:100)
        at junit.framework.Assert.assertEquals(Assert.java:107)
        at com.test.onesignal.GenerateNotificationRunner.shouldContainPayloadWhenOldSummaryNotificationIsOpened(GenerateNotificationRunner.java:345)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants