Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature set language callbacks #1536

Merged
merged 9 commits into from
Mar 1, 2022
Merged

Feature set language callbacks #1536

merged 9 commits into from
Mar 1, 2022

Commits on Feb 14, 2022

  1. Add getLanguage to StateSynchronizers 

    * Add getLanguage to OneSignalStateSynchronizer and UserStatePushSynchronizer
    @tanaynigam
    tanaynigam committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    fb747a0 View commit details
    Browse the repository at this point in the history

  2. Add OSDeviceInfoError and OSDeviceInfoCompletionHandler 

    * Add OSDeviceInfoError and OSDeviceInfoCompletionHandler to OneSignal.java
    @tanaynigam
    tanaynigam committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    22cb57b View commit details
    Browse the repository at this point in the history

  3. Add DeviceInfoHandlers to UserStateSynchronizer 

    * Add deviceInfoCompletionHandler
* Add deviceInfoHandlersPerformOnSuccess
* Add deviceInfoHandlersPerformOnFailure
    @tanaynigam
    tanaynigam committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    2b6758d View commit details
    Browse the repository at this point in the history

  4. Update updateDeviceInfo 

    * Update updateDeviceInfo by adding OSDeviceInfoCompletionHandler
    @tanaynigam
    tanaynigam committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    1fc53c6 View commit details
    Browse the repository at this point in the history

  5. Add completionHandler to setLanguage 

    * Add setLanguage with completion handler
* setLanguage without completion handler calls null on completion handler
* Add OSDeviceInfo completion handler to setLanguage
    @tanaynigam
    tanaynigam committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    d006c5b View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Add OSLanguageCompletionHandler 

    * Add OSLanguageCompletionHandler
* Add OSLanguageError
* Update setLanguage with OSLanguageCompletionHandler
    @tanaynigam
    tanaynigam committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    ed749cb View commit details
    Browse the repository at this point in the history

  2. Add setLanguage callback Unit Tests 

    * Add TestSetLanguageHandler for unit test setLanguage with callback setup
* Add shouldSetLanguageWithResponse to check for success callback
* Add shouldFailToSetLanguageWithResponse to check for failure callback
    @tanaynigam
    tanaynigam committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    e20e048 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Move OSDeviceInfoError and handler 

    * Move OSDeviceInfoError and OSDeviceInfoCompletionHandler to OneSignalStateSynchronizer
* Add appropriate imports in files OneSignal.java, OneSignalStateSynchronizer and UserStateSynchronizer
    @tanaynigam
    tanaynigam committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    46b9576 View commit details
    Browse the repository at this point in the history

  2. Update comment setLanguage Unit Test 

    * Update comment in setLanguage with success handler in Unit Test
    @tanaynigam
    tanaynigam committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    162fbf8 View commit details
    Browse the repository at this point in the history