[Fix] groupless heads-up style notifications from redisplaying previous #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where if notifications were shown as heads-up style and a 4th notification is displayed all previous notifications would show again. We need to regenerate these notifications to attach a group but we didn't use setOnlyAlertOnce(true) to prevent showing as heads up again.
assignGrouplessNotifications is only ever needed for Android 7.0 (N) and higher so bumped this requirement. Also the Android 6.0 (M) implementation was incomplete, it never assigned anything from the old notification.
emawby
approved these changes
Jun 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix bug where if a 4th, 5th, etc notification was displayed with the heads-up style and no group was set the previous notifications would re-display.
Details
Motivation
This bug can be confusing to end users and creates a lot of visual noise with old notification reshowing as heads-up.
Scope
Only effects notification display when no group is used, and 4 or more are displayed for the app. Effects Android 7.0 and newer.
Testing
Unit testing
None, Robolectric does not simulate this specific detail.
Manual testing
Tested on an Android 11 emulator, ensuring I could reproduce the issue and the issue no longer happens after the fix.
Videos
Before Fix
Android_Groupless_notication_redisplay_bug-captured_Android11_emu.mp4
After Fix
Android_Groupless_notification_bug_fixed_with_setOnlyAlertOnce-Android11_emu.mp4
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is