Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix individually clearing notifications #1711

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Dec 30, 2022

Description

One Line Summary

This PR fixes bug where swiping the latest notification (>=4) dismisses all current notifications.

Details

Motivation

Bug fix

Scope

Notification storage and clearing

Testing

Unit testing

Unit test testIndividualGrouplessSummaryNotificationDismissal added for future testing, but the bug is not reproducible using this test since removeNotification does not get the behavior from swiping.

Manual testing

Successfully manually tested solution on Android emulator.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Previously, swiping away the latest notifications (when 4+ are present) would clear all notifications. Fix allows for individual dismissal only of those swiped.
Copy link
Contributor

@emawby emawby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fhboswell fhboswell requested review from fhboswell and removed request for fhboswell January 4, 2023 00:47
@jennantilla jennantilla merged commit 4cb7305 into main Jan 4, 2023
@jennantilla jennantilla deleted the fix/individually_clear_notifications branch January 4, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants