-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix language not being set #1847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Sep 21, 2023
...ain/java/com/onesignal/user/internal/operations/impl/executors/LoginUserOperationExecutor.kt
Outdated
Show resolved
Hide resolved
jkasten2
approved these changes
Sep 22, 2023
…er.languageContext()
nan-li
changed the base branch from
user-model/main
to
fix/timezone_id_not_set
September 22, 2023 20:29
nan-li
approved these changes
Sep 22, 2023
Merged
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix language not being set
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix language not being set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This fixes an issue where language was not being set as a user property when a new user is created.
Details
This issue resulted in language being set as "en" by default despite device settings.
In order to send the language we are building upon the properties map added in #1842. An additional property set there (language) will be hydrated to the properties model when the response is received.
This fixes #1843
Motivation
Ensure language matches device.
Scope
user properties during createUser
Testing
Unit testing
Added language to properties object in unit tests. Ran/passed unit tests.
Manual testing
Tested a fresh install with a Pixel 7 emulator running Android 13 with device language set to French. User is created with language code 'fr' and reflected in dashboard.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is