Fix IAMs showing erroneously on every cold start #1863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix IAMs displaying on every cold start when they shouldn't be (such as they should only display once or not meeting the time between redisplays).
Details
Motivation
Fix reports of this issue above.
Scope
The fix is to read in dismissed IAMs on IAM Manager start
_dismissedMessages
.start()
_dismissedMessages
list was always empty, redisplay data was not passed on to the fetched IAMs, so these IAMs believed they had never been displayed.Testing
Unit testing
None
Manual testing
Android emulator API 33
Tested cold starts and backgrounding with these type of IAMs
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is