Add requiresUserPrivacyConsent() getter #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Since developers can manually require consent by editing the manifest, the wrapper SDK's need a way of knowing if the Android SDK is waiting on the user's privacy consent • Exposes a public getter that returns TRUE if consent is required but hasn't been provided yet.
• Adds a testcase to make sure that the new requiresUserPrivacyConsent() method returns correct results
Nightsd01
added a commit
to OneSignal/OneSignal-Flutter-SDK
that referenced
this pull request
Jul 23, 2018
• Added a new getter method in the android native SDK (pull request = OneSignal/OneSignal-Android-SDK#598) • This new method returns a boolean indicating if the SDK is waiting for user privacy consent before it initializes • This new getter method makes the behavior for `requiresUserPrivacyConsent()` the same as it is implemented in iOS
jkasten2
approved these changes
Jul 23, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Since developers can manually require consent by editing the manifest, the wrapper SDK's need a way of knowing if the Android SDK is waiting on the user's privacy consent
• Exposes a public getter that returns TRUE if consent is required but hasn't been provided yet.
This change is