Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Privacy Consent Requirement to Add Observers #655

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Remove Privacy Consent Requirement to Add Observers #655

merged 2 commits into from
Oct 26, 2018

Commits on Oct 25, 2018

  1. Remove Privacy Consent Requirement to Add Observers 

    • Apps should be able to add observers (ie. addSubscriptionObserver) even if privacy consent has not yet been granted.
    @Nightsd01
    Nightsd01 committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    2426551 View commit details
    Browse the repository at this point in the history

  2. Add Regression Tests 

    • Adds tests to make sure that apps can add the observers even if privacy consent hasn't been granted
• The tests verify that the observers fire correctly once consent is granted.
    @Nightsd01
    Nightsd01 committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    5a7e9f9 View commit details
    Browse the repository at this point in the history