Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Adds SDK support to allow developers to map their own system's user identifiers to OneSignal users, this way they don't have to save the user's OneSignal user ID
• This PR adds two new methods:
setExternalUserId(String)
: Sets the external ID for the current user. OneSignal maintains separate account records internally for both Email and Push accounts, so if a device has a Push subscription and has also set an Email subscription, this method will generate two API requests.removeExternalUserId
: This method is actually just a wrapper on top ofsetExternalUserId
except that it sends an empty string as the external user ID. This is because our API requires an empty string instead of null to remove the external ID• Adds tests to verify that the external ID methods generate correctly formatted API requests for both Push and Email players
This change is