Set External User ID #679
Merged
Set External User ID #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Adds public methods setExternalUserId() and removeExternalUserId() that let developers map their own userID's in our system • TODO: Add tests to ensure the methods generate correct API requests and that it uses the on_session request if it hasn't already occurred
• It turns out the Android SDK already has a state synchronizer that can persist previously set player values and will not send duplicate requests if the value is unchanged. • This commit switches to utilizing then state synchronizer • Adds a new test to make sure that the external ID is not sent if setExternalUserId() is called but the ID is the same as the previous session/s
jkasten2
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Adds SDK support to allow developers to map their own system's user identifiers to OneSignal users, this way they don't have to save the user's OneSignal user ID
• This PR adds two new methods:
setExternalUserId(String): Sets the external ID for the current user. OneSignal maintains separate account records internally for both Email and Push accounts, so if a device has a Push subscription and has also set an Email subscription, this method will generate two API requests.removeExternalUserId: This method is actually just a wrapper on top ofsetExternalUserIdexcept that it sends an empty string as the external user ID. This is because our API requires an empty string instead of null to remove the external ID• Adds tests to verify that the external ID methods generate correctly formatted API requests for both Push and Email players
This change is