[User Model] Add GetTags #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emawby
commented
Dec 18, 2023
| @@ -35,6 +35,7 @@ public void Initialize() | |||
| public void AddTags(IDictionary<string, string> tags) => OneSignalNative.User.AddTags(tags); | |||
| public void RemoveTag(string key) => OneSignalNative.User.RemoveTag(key); | |||
| public void RemoveTags(params string[] keys) => OneSignalNative.User.RemoveTags(keys); | |||
| public IDictionary<string, string> GetTags() => OneSignalNative.User.GetTags(); | |||
There was a problem hiding this comment.
error CS1061: 'IUserManager' does not contain a definition for 'GetTags' and no accessible extension method 'GetTags' accepting a first argument of type 'IUserManager' could be found (are you missing a using directive or an assembly reference?) [/Users/elliotmawby/Documents/GitHub/OneSignal-DotNet-SDK/OneSignalSDK.DotNet.Android/OneSignalSDK.DotNet.Android.csproj::TargetFramework=net7.0-android]
emawby
force-pushed
the
user-model/getTags
branch
from
b357ff3
to
8e89819
Compare
emawby
force-pushed
the
user-model/dotnet7-upgrade
branch
from
674badb
to
de8eb8c
Compare
This crashes with a target invocation exception
emawby
force-pushed
the
user-model/getTags
branch
from
8e89819
to
db58658
Compare
1 task
shepherd-l
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
LGTM
getTags correctly reflected the user's tags when I added and removed tags in the example app.
Tested on
Android Emulator: Pixel 4 API 31
iOS Simulator: iPhone 15 iOS 17
However addTags sends the incorrect value on iOS (mentioned here: #78)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add GetTags to the User Model SDK
Details
I recommend reviewing by commit since the iOS binary bump includes a lot of file changes
Motivation
Add ability to get the current users tags. Tags are refreshed whenever fetchUser is called (start of session or user change) and are otherwise up to date as tags are changed locally.
Scope
Android and iOS. New method on User namespace
Testing
Unit testing
N/A
Manual testing
Tested on iOS and Android using sample app built in vscode with maui extension
Affected code checklist
Checklist
Overview
Testing
Final pass