Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Migration guide fixes to service worker name, async, and small misc #1065

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jul 27, 2023

Description

1 Line Summary

Migration guide fixes to service worker name, async, and other small misc improvements.

Details

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

In a previous beta we suggested renaming the service work file hosted
by the customer but decided to keep it the same to make migration
easier.
* OneSignalSDKWorker.js - hosted by customer
* OneSignalSDK.sw.js - hosted by cdn.onesignal.com
Base automatically changed from user-model/update-sandbox-sw-names to user-model/v1 July 28, 2023 18:39
@jkasten2 jkasten2 merged commit b5ec97d into user-model/v1 Jul 28, 2023
2 checks passed
@jkasten2 jkasten2 deleted the user-model/migration-guide-fixups-post-beta5 branch July 28, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants