Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User model/ios badges #1068

Closed
wants to merge 2 commits into from
Closed

User model/ios badges #1068

wants to merge 2 commits into from

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Jul 27, 2023

Description

1 Line Summary

Details

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Motivation: will be used to set the badge count on the app as documented here: (https://developer.mozilla.org/en-US/docs/Web/API/Notification/badge)
Motivation: set the app badge count from the SW
Base automatically changed from user-model/v1 to main August 15, 2023 23:20
@jkasten2 jkasten2 removed their request for review October 19, 2023 22:11
@rgomezp rgomezp closed this Feb 6, 2024
@rgomezp rgomezp deleted the user-model/ios-badges branch February 6, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants