-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0.0] Notification Foreground Listener - API update #1258
Merged
emawby
merged 10 commits into
5.0.0/iam_lifecycle_listener_api
from
5.0.0/notification_foreground_listener_api
May 1, 2023
Merged
[5.0.0] Notification Foreground Listener - API update #1258
emawby
merged 10 commits into
5.0.0/iam_lifecycle_listener_api
from
5.0.0/notification_foreground_listener_api
May 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename notificationWillShowInForegroundHandler to OSNotificationLifecycleListener * It will have the `onWillDisplay` event.
nan-li
commented
Apr 28, 2023
|
||
- (void)preventDefault { | ||
[OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"OSNotificationWillDisplayEvent.preventDefault called."]]; | ||
_isPreventDefault = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for both
✍️ TODO: To support multiple listeners, we will prevent default if any of them call |
* Rename OSPushSubscriptionStateChanges to OSPushSubscriptionChangedState * Rename event from onOSPushSubscriptionChanged to onPushSubscriptionDidChange * Use current and previous instead of to and from * No other logic changes, only naming
* It can just use the `wantsToDisplay` property of the notification it owns.
* Rename click block to `OSInAppMessageClickListener` * Rename `setClickHandler` to `addClickListener` * Add a remove method for the click listener * OSInAppMessageAction has basically been renamed to OSInAppMessageClickResult * OSInAppMessageClickEvent will be passed to developers instead of OSInAppMessageAction and the event will contain an in app message and a click result.
OSInAppMessageDelegate and handleMessageAction not used by anything
* We have some legacy logic about IAM direct influence but if there are multiple click listeners added, we only want this to update once, and not for every listener.
* Rename setNotificationOpenedHandler -> addClickListener, removeClickListener * Rename object `OSNotificationOpenedResult` -> `OSNotificationClickEvent` * Rename object `OSNotificationAction` -> `OSNotificationClickResult` * Support having multiple listeners
…ener_api [5.0.0] Notification Click Listener - API update
[5.0.0] IAM Click Listener - API update
…ver_api [5.0.0] Push Subscription Observer - API update
emawby
approved these changes
May 1, 2023
Merged
18 tasks
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
…_listener_api [5.0.0] Notification Foreground Listener - API update
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
…_listener_api [5.0.0] Notification Foreground Listener - API update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update Notification Foreground Listener API.
Details
Motivation
Update APi.
Scope
onWillDisplay
event.NOTE: I did not update the timeout time and it is still 25 seconds to call
display()
and this time is not updated to 30 seconds due to iOS limitation. For example, callingdisplay()
29 seconds later would not display the notification.OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is