Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User model] Remove launch urls in app #1275

Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Jul 10, 2023

Description

One Line Summary

Removing the launch urls in app feature

Details

We are removing the launch push notification urls in a webview feature. This feature was not consistently effective, and added a webkit dependency to notifications that has gotten apps rejected from the app store. If we later want to add this feature back we should consider it as an optional module.

Motivation

Don't depend on Webkit and remove legacy feature.

Scope

notifications/InAppMessages

Testing

Unit testing

Manual testing

Builds successfully. All URLs are launched by the system

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the base branch from main to user_model/modularize_location July 10, 2023 21:59
@emawby emawby force-pushed the user_model/remove_launch_urls_in_app branch from 2e6dba9 to f451e06 Compare July 10, 2023 22:03
@emawby emawby force-pushed the user_model/modularize_location branch 2 times, most recently from 41ef681 to 441e361 Compare July 12, 2023 20:03
We are removing the launch push notification urls in a webview feature. This feature was not consistently effective, and added a webkit dependency to notifications that has gotten apps rejected from the app store. If we later want to add this feature back we should consider it as an optional module.
@emawby emawby force-pushed the user_model/remove_launch_urls_in_app branch from f451e06 to 8350017 Compare July 13, 2023 20:38
@emawby emawby merged commit 0dc4f15 into user_model/modularize_location Jul 13, 2023
1 check failed
@emawby emawby deleted the user_model/remove_launch_urls_in_app branch July 13, 2023 20:38
nan-li pushed a commit that referenced this pull request Oct 30, 2023
…_in_app

[User model] Remove launch urls in app
nan-li pushed a commit that referenced this pull request Oct 30, 2023
…_in_app

[User model] Remove launch urls in app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants