Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User model] Fix in app display #1294

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 10, 2023

Description

One Line Summary

cherry pick #1276 to the user model branch

Details

We now always clean up the entire IAM window when an in app is dismissed

Motivation

Fixes an issue where IAMs with the same trigger were not being displayed back to back

Scope

IAMs

Testing

Manual testing

Tested with on app open trigger IAMs including permission prompts

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the base branch from main to 5.0.0/create_user_error August 10, 2023 00:37
The JS dismiss event is being sent to the SDK twice. Make sure we don't dismiss twice or the second IAM in the queue will be dismissed before it is displayed
@emawby emawby merged commit c2a9be3 into 5.0.0/create_user_error Aug 10, 2023
1 check failed
@emawby emawby deleted the user_model/fix_in_app_display branch August 10, 2023 17:24
nan-li pushed a commit that referenced this pull request Oct 30, 2023
nan-li pushed a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants