-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User model] enable push for simulators #1297
[User model] enable push for simulators #1297
Conversation
@@ -217,6 +217,9 @@ class OSSubscriptionModel: OSModel { | |||
|
|||
// Set test_type if subscription model is PUSH | |||
if type == .push { | |||
#if targetEnvironment(simulator) | |||
self.testType = OSUIApplicationReleaseMode.UIApplicationReleaseDev.rawValue | |||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.testType
will just be overwrite below. In order to prevent that we need to use an #else
here or some kind of early return logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is fine if we are able to properly detect that it is an AdHoc or wildcard build on the simulator I want it to be overwritten. The issue is when the release mode is "unknown"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that wasn't clear. I recommend a comment or explicitly only doing that logic when it is unknown
then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to only set if the mode is unknown
Cherry-pick of #1244 Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
887b6b8
to
3e64983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…mulators [User model] enable push for simulators
…mulators [User model] enable push for simulators
Description
One Line Summary
Enable push for simulators. Equivalent to #1244
Details
Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles.
This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
Scope
push on simulators
Testing
Manual testing
tested receiving push on a simulator
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is