[User model] enable push for simulators #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Aug 10, 2023
| @@ -217,6 +217,9 @@ class OSSubscriptionModel: OSModel { | |||
|
|
|||
| // Set test_type if subscription model is PUSH | |||
| if type == .push { | |||
| #if targetEnvironment(simulator) | |||
| self.testType = OSUIApplicationReleaseMode.UIApplicationReleaseDev.rawValue | |||
| #endif | |||
There was a problem hiding this comment.
self.testType will just be overwrite below. In order to prevent that we need to use an #else here or some kind of early return logic.
There was a problem hiding this comment.
That is fine if we are able to properly detect that it is an AdHoc or wildcard build on the simulator I want it to be overwritten. The issue is when the release mode is "unknown"
There was a problem hiding this comment.
ah, that wasn't clear. I recommend a comment or explicitly only doing that logic when it is unknown then.
There was a problem hiding this comment.
I updated it to only set if the mode is unknown
Cherry-pick of #1244 Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
emawby
force-pushed
the
user_model/enable_push_for_simulators
branch
from
887b6b8
to
3e64983
Compare
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
…mulators [User model] enable push for simulators
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
…mulators [User model] enable push for simulators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Enable push for simulators. Equivalent to #1244
Details
Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles.
This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
Scope
push on simulators
Testing
Manual testing
tested receiving push on a simulator
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is