[User Model] Add back the dropshadow to In App Messages with a plist option to disable it #1395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add back the dropshadow to In App Messages with a plist option to disable it
Details
The drop shadow was removed from iOS In App Messages to support transparent In App Messages. However this results in banner IAMs not looking correct if the background color of the message matches the color of the app underneath it.
To solve both use cases developers can now use boolean plist setting
OneSignal_in_app_message_hide_drop_shadow
to toggle if they want a drop shadow or not. Note that this is a setting that would apply to all in app messages.Examples without the dropshadow
Examples with the dropshadow
Motivation
Banner IAMs look incorrect when matching the background color of the app
Scope
New and existing In App Messsage visual behavior
Testing
Unit testing
n/a
Manual testing
tested on multiple IAM types with a simulator without plist, with plist option to yes, and with plist option to no
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is