Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit misleading fatal-level log for wrappers #1468

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Omit misleading fatal-level log for wrappers #1468

merged 2 commits into from
Aug 9, 2024

Commits on Aug 6, 2024

  1. Log Fatal log for null app ID only on native SDK 

    * Wrapper SDKs will automatically initialize with null app ID.
* On wrappers, this fatal log is very misleading, so only log if this happens on the native SDK.
* Most wrappers also have type signatures indicating app ID should be non-null for the public initialize API
    @nan-li
    nan-li committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    966d072 View commit details
    Browse the repository at this point in the history

  2. Remove setLaunchOptions from OneSignal header 

    * This was added to the OneSignalFramework header file to expose to wrappers.
* However, wrappers do not actually use this because they must initialize the SDK (not sufficient to only set launch options) so cold start click listeners can be triggered.
* Remove from header so it is not misleading, which suggests it is used.
    @nan-li
    nan-li committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d2eca16 View commit details
    Browse the repository at this point in the history