Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a reason for marked_bad server fn #3

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Require a reason for marked_bad server fn #3

merged 1 commit into from
Dec 4, 2023

Conversation

alecharmon
Copy link

No description provided.

@alecharmon alecharmon marked this pull request as ready for review December 4, 2023 14:35
@nicolasvan nicolasvan requested a review from a team December 4, 2023 15:17
nicolasvan
nicolasvan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nicolasvan nicolasvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecharmon alecharmon merged commit 53bbc8f into main Dec 4, 2023
@nicolasvan nicolasvan mentioned this pull request Dec 4, 2023
Merged
@niels-s niels-s deleted the marked-bad-reason branch December 4, 2023 18:54
@niels-s
Copy link
Member

niels-s commented Dec 4, 2023

@alecharmon can we commit this also to upstream pgcat?
We really like to run upstream as soon as possible again so we don't diverge and get all new bugfixes and features in too.

@alecharmon
Copy link
Author

@niels-s sure thing - just submitted postgresml#654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasvan nicolasvan nicolasvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecharmon @niels-s @nicolasvan