-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suddenly lots of crashes on android related to onesignal #1501
Comments
Hi @pierroo, Thank you for reporting this and I apologize for the sudden crashes you are seeing. Can you confirm you are on react-native-onesignal In the latest release 4.5.1, we included a speculative fix for an Android WorkManager crash people have been reporting in production. It looks like it is having very unexpected effects, I'm quite perplexed, but in the meantime, please downgrade to the previous version of this library. Can you answer some questions to help me understand what is happening?
|
Hi @pierroo, Thank you for the information. I am even more perplexed you are not on Because in release 4.5.0, we only updated the native iOS SDK, and there were no Android changes. I see
^ I am not sure of the answer to this because I think you are already on
OneSignal-Android-SDK |
That is confusing then, because I can guarantee all those crashes are from v4.5.0 So the onesignal Android sdk where do I find it ? I really don't want to push in production 4.5.1 if it crashes even more; anything else I could provide to help with it ? |
Did you update to 4.5.0 from 4.4.1? Or an earlier version? We didn't make any Android changes at all in 4.5.0 so I am not sure how to advise. You can check any of the Another way to check is seeing if a bug we fixed is still in the app.
|
I checked in both build.gradle, there is no mention of " api 'com.onesignal:OneSignal:4.8.2' " (or any other version) While I investigate further so I can provide more materials here, my initial question remains: |
Hi @pierroo, What version did you upgrade to 4.5.0 from? I can see what changes were made since the previous version you were on.
This comment was when I thought you were using For now, please let me know the previous version you were using before 4.5.0. |
I came from 4.3.8 |
Hi @pierroo, Now that I am looking at the stack trace again, it may not be the same issue I thought it was on You can update to 4.5.1 from 4.5.0 but it will probably not resolve these crashes because there were no fixes that could be applied to your case. I have some more questions:
|
Hi @nan-li , I can barely retrieve those crash on my newest production release (the one with 4.5.0), whereas they mostly (95%) seem to be from the previous production release instead (thus the 4.3.8) And if that still matters, you are right, all those crashes did not involve samsung devices, only variant of the android OS. Thank you for your time, |
Hey @pierroo thanks for the update. Please keep us posted on your version update and if any other issues arise. |
Closing for now feel free to reopen if there are issues |
What happened?
On android, the google play console suddenly brings a lots of crashes since my latest version where I updated onesignal to 4.5.0.
Here is the stack (same for all crashes)
Steps to reproduce?
What did you expect to happen?
No crash
React Native OneSignal SDK version
4.5.0
Which platform(s) are affected?
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: