Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default values in liquid IAMs #1698

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Dec 6, 2022

Description

One Line Summary

Fix default values in liquid IAMs

Details

Motivation

Bug with In-App Messages where the liquid syntax for tag substitution was showing up in IAMs of users with no tags. String formatting failed when a user has no tags due to trying to format null instead of empty string.

Before:
Screenshot 2022-12-06 at 10 35 42 AM

After:
Screenshot 2022-12-06 at 10 36 17 AM

Scope

In-App Messages

Testing

Unit testing

No unit tests available.

Manual testing

Tested updating the value of userTagsSent to an empty string and the In-App Message displays as expected on Android 12.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

String formatting failed when a user has no tags due to trying to format with null instead of empty string.
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @emawby and @nan-li)

Copy link
Contributor

@nan-li nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! If you have an image of the IAM before and after, it'd be great to include in the PR description if we ever look back at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants