Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] GA Upates #1537

Merged
merged 7 commits into from
Aug 18, 2023
Merged

[User Model] GA Upates #1537

merged 7 commits into from
Aug 18, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Aug 16, 2023

Description

One Line Summary

Updates for User Model GA release.

Details

  • Add setLaunchURLsInApp deprecation notice in Migration Guide
  • Update code examples for logLevel and alertLevel to reflect beta-02 type update to enum
  • Refactor pushSubscription to camel case to align with TS convention where pushSubscription is more of a property than a class or module
  • Bump native versions to the GA releases

Motivation

  • Update native iOS SDK to 5.0.1
  • Update native Android SDK to 5.0.0

Testing

Manual testing

Manually tested on an Pixel 6 emulator running Android 13 and iPhone 14 simulator running iOS 16.4.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jennantilla jennantilla marked this pull request as ready for review August 16, 2023 20:10
Copy link

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 3 unresolved discussions (waiting on @emawby, @jennantilla, and @nan-li)


MIGRATION_GUIDE.md line 1 at r1 (raw file):

# React Native v5.0.0-beta-02 Migration Guide

I also almost forgot to do this but, you should remove beta-02 for the GA release


MIGRATION_GUIDE.md line 379 at r1 (raw file):

# Limitations

- This is a Beta release so please test thorougly prior to production use.

Same here. I also put down the same limitations the native SDKs have, ex. iOS


MIGRATION_GUIDE.md line 386 at r1 (raw file):

- Identity Verification
  - We will be introducing JWT in a follow-up Alpha or Beta release.

Same here, remove beta reference

* Remove beta flag
* Fix syntax error in permissionChange code example
Copy link

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @emawby and @jennantilla)


MIGRATION_GUIDE.md line 380 at r2 (raw file):

- Changing app IDs is not supported.
- Any `User` namespace calls must be invoked **after** initialization. Example: `OneSignal.User.addTag("tag", "2")`

I think you can also add
"- In the SDK, the user state is only refreshed from the server when a new session is started (cold start or backgrounded for over 30 seconds) or when the user is logged in. This is by design."
like in the native SDKs, ex. iOS

@nan-li nan-li requested a review from shepherd-l August 18, 2023 20:59
Copy link

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @emawby)

@nan-li nan-li merged commit 3472b8b into major_release_5.0.0 Aug 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants