-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Model] GA Upates #1537
[User Model] GA Upates #1537
Conversation
* Align with TS convention where pushSubscription is more of a property than a class or module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 3 unresolved discussions (waiting on @emawby, @jennantilla, and @nan-li)
MIGRATION_GUIDE.md
line 1 at r1 (raw file):
# React Native v5.0.0-beta-02 Migration Guide
I also almost forgot to do this but, you should remove beta-02 for the GA release
MIGRATION_GUIDE.md
line 379 at r1 (raw file):
# Limitations - This is a Beta release so please test thorougly prior to production use.
Same here. I also put down the same limitations the native SDKs have, ex. iOS
MIGRATION_GUIDE.md
line 386 at r1 (raw file):
- Identity Verification - We will be introducing JWT in a follow-up Alpha or Beta release.
Same here, remove beta reference
* Remove beta flag * Fix syntax error in permissionChange code example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @emawby and @jennantilla)
MIGRATION_GUIDE.md
line 380 at r2 (raw file):
- Changing app IDs is not supported. - Any `User` namespace calls must be invoked **after** initialization. Example: `OneSignal.User.addTag("tag", "2")`
I think you can also add
"- In the SDK, the user state is only refreshed from the server when a new session is started (cold start or backgrounded for over 30 seconds) or when the user is logged in. This is by design."
like in the native SDKs, ex. iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @emawby)
Description
One Line Summary
Updates for User Model GA release.
Details
pushSubscription
to camel case to align with TS convention where pushSubscription is more of a property than a class or moduleMotivation
Testing
Manual testing
Manually tested on an Pixel 6 emulator running Android 13 and iPhone 14 simulator running iOS 16.4.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is