Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1 and R1 Buttons No Longer Page Up/Down in Game List #880

Closed
3 tasks done
Phanturian opened this issue Jun 3, 2023 · 2 comments
Closed
3 tasks done

L1 and R1 Buttons No Longer Page Up/Down in Game List #880

Phanturian opened this issue Jun 3, 2023 · 2 comments
Labels
fw/frontend related Only Miyoo can resolve this

Comments

@Phanturian
Copy link

Checklist

  • I am reporting a bug in the Onion OS (Note that Onion devs can’t fix inherited issues with RA Cores)
  • I have reviewed the Onion Wiki and did not find the answer
  • I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

Onion-v4.2.0-beta-dev-3ce1f62

Miyoo Firmware Version

202303262339

Provide a clear and concise description of the issue

The L1 and R1 buttons no longer page up/down or scroll in any list. Pressing L1 or R1 still presents the click, or sound effect associated with scrolling, but nothing happens. L2 and R2 are now assigned to page up/down or scroll, but with no click or sound effect.

Steps to Reproduce

  1. Install Onion 4.2.0 Beta
  2. Navigate to a list of games
  3. Press L1 or R1

Provide any additional context or information that may help us investigate your issue

I have the setting to swap L1/R1 with L2/R2 turned off, although this has no effect on the page up/down scrolling in menus.
@schmurtzm
Copy link
Member

Yes Miyoo has changed the page scroll mapping from L1/R1 to L2/R2 and they forgot to move the sound affectation.
This bad sound affectation impacts Onion on this bug : #952
We can hope that it will be fixed on a future MainUI version from Miyoo 🤞

@schmurtzm schmurtzm added the fw/frontend related Only Miyoo can resolve this label Jun 23, 2023
schmurtzm added a commit that referenced this issue Jun 23, 2023
@schmurtzm
Disable quietMainUI
f3a5a4b 
Issue for Onion to suppress the clic clic clic sound : #952

Issue for Miyoo / MainUI to remap the sound on the right shoulder buttons : #880
@schmurtzm schmurtzm mentioned this issue Jun 23, 2023
Merged
Aemiii91 added a commit that referenced this issue Jun 30, 2023
@schmurtzm @Aemiii91
Fix roms scrolling when long press menu button to add a rom in favori…
804294a 
…te (#953)

* Disable quietMainUI

Issue for Onion to suppress the clic clic clic sound : #952

Issue for Miyoo / MainUI to remap the sound on the right shoulder buttons : #880

* Update menuButtonAction.h

deletion of the second occurrence

* Enable silent long press again

Now that tGecko have remapped sound to L2/R2 and no sound to L1/R1 (#959) we can enable again the fake L1 sendkeys to have a silent long press with menu button.

Related issue : #952

Discord RGH conversation : https://discord.com/channels/529983248114122762/1007796369785897090/1123317647212302406

---------

Co-authored-by: Aemiii91 <[email protected]>
Co-authored-by: Aemiii91 <[email protected]>
@Aemiii91
Copy link
Member

Fixed in #959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fw/frontend related Only Miyoo can resolve this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schmurtzm @Aemiii91 @Phanturian