REFACTOR: Better Launchbox scraper #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
schmurtzm
commented
Aug 3, 2023
schmurtzm
commented
- Now use SQLite databases thanks to the Launchbox-To-SQLite database converter (https://github.com/schmurtzm/Launchbox-To-SQLite)
- adding a lot of platforms
- faster and more efficient search
- Workaround : using jpg2png_stb (https://github.com/fishcu/image_convert_and_resize) when jpg2png crash due to GFX memory limitation (jpg2png is still used by default as it is a lot faster)
- Now use SQLite databases thanks to the Launchbox-To-SQLite database converter (https://github.com/schmurtzm/Launchbox-To-SQLite) - adding a lot of platforms - faster and more efficient search - Workaround : using jpg2png_stb (https://github.com/fishcu/image_convert_and_resize) when jpg2png crash due to GFX memory limitation (jpg2png is still used by default as it is a lot faster)
Aemiii91
approved these changes
Aug 3, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2023
- Implementation of "Media Type" selection in the configuration (it applies to every scrapers) - Implementation of "region" selection in the configuration (it applies to Screenscraper and Launchbox) (big work to determine the used regions on each scraper, put all these in a database and create fallback for each : for example search order fr -> eu -> world ...) - Launchbox scraper totally rewrited (region and media types management, updated [internal database](https://github.com/schmurtzm/Launchbox-To-SQLite) and [include previous update](#1098)) - Improved the search by CRC for screenscraper (use xcrc, skip when the file is too big) - Improved the input of text thanks to readline ([source](ed6b3eb)) binary (it allows to move the cursor without displaying special characters) - Added a new option in screenscraper settings to easily check credentials and have account statistics. - Added an automatic config repair tool, it serves several purposes : _ during update : will add missing keys with default value _ missing config file : will create it with default value. _ corrupted config file : will re-create it with default value. - Many fixes and optimizations by: schmurtzm with the collaboration of t0b10-t3nm4 --------- Co-authored-by: t0b10-t3nm4 <[email protected]> Co-authored-by: t0b10-t3nm4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.