Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic (no pin) WPS function to Tweaks #884

Merged
merged 18 commits into from
Jun 14, 2023
Merged

Add basic (no pin) WPS function to Tweaks #884

merged 18 commits into from
Jun 14, 2023

Conversation

XK9274
Copy link
Member

@XK9274 XK9274 commented Jun 5, 2023

Tweaks_013
Tweaks_014

Video showing successful connection

20230607232509.mp4

Adds:

  • WPS connection ability through Tweaks -> Network -> WPS...

Icon meaning:

wifiquery - Querying wifi state
wifiup - Wifi already up/brought up by script
wpstrying - Trying to connect (Alternates between red/orange)
wpsfail - Failed to connect
wpsconnected - Connected and got an IP

Files added

/.tmp_update files

Other changes

Minor change to update_networking.sh to fix an issue after adding a wlan0 check to wpsclient.sh and forcing wifi up

Usage

  • Press WPS button on router
  • Press WPS connect button in tweaks (Wifi state doesn't matter, script will bring it up for you)
  • Observe icon flashing red/orange indicating attempting to connect
  • Observe icon flashing green indicating successfull connection
  • Observe icon flashing red indicating failed connection

Issues

  • Icons flicker outside Tweaks due to MainUI redraw.

XK9274 and others added 12 commits June 5, 2023 18:39
## Adds:
- WPS connection ability through Tweaks -> Network

## Files added
- 3 icons (Need discussing)
- imgpop bin to show image on screen: https://github.com/XK9274/imgpop-miyoo
- SDL lib for imgpop

## Other changes
N/A

## Usage
- Press WPS button on router
- Press WPS connect button in tweaks
- Observe icon flashing red/orange indicating attempting to connect
- Observe icon flashing green indicating successfull connection
- Observe icon flashing red indicating failed connection

## Issues
- converting to draft to discuss icon/location/type of notifcation to user.
Added WPS into a submenu as I'll be adding WPS host into this same submenu. Fix some formatting.
Checks if the wlan0 interface exists/is enabled, if not runs AXP on and starts a supplicant/udhcpc process.

Shows new logos when querying wifi state
Remove a duped udhcpc kill that could cause blackscreen issues.
Tell MainUI that wifi needs to be kept up once started, if you dont do this it stays "off" in settings and the next time MainUI starts wifi is again turned off as the value is still 0.
Issue caused by check_wifi in update_networking realising wifi set to 0 and killing wifi after using WPS.

Removed unnecessary loop
check_wifi realises Wifi was set to 0 in settings.json and kills wifi after relaunching MainUI (after a WPS connection)
@XK9274 XK9274 marked this pull request as ready for review June 7, 2023 23:14
Aemiii91
Aemiii91 previously approved these changes Jun 14, 2023
@Aemiii91 Aemiii91 enabled auto-merge June 14, 2023 19:46
@Aemiii91 Aemiii91 added this pull request to the merge queue Jun 14, 2023
@Aemiii91 Aemiii91 removed this pull request from the merge queue due to a manual request Jun 14, 2023
@Aemiii91 Aemiii91 enabled auto-merge June 14, 2023 20:32
@Aemiii91 Aemiii91 added this pull request to the merge queue Jun 14, 2023
Merged via the queue into main with commit dd2e93e Jun 14, 2023
@Aemiii91 Aemiii91 deleted the add-wps-function branch June 14, 2023 20:46
@Aemiii91 Aemiii91 added the enhancement New or improved feature label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants