Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing unzip with 7z in installer #911

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Replacing unzip with 7z in installer #911

merged 1 commit into from
Jun 16, 2023

Conversation

schmurtzm
Copy link
Member

New:

  • 7z is used instead of unzip during Onion installation

Fixes:

  • No more failure during extract with big onion.pak

@schmurtzm
Replacing unzip with 7z in installer
7c2e841 
7z is more reliable than unzip from the busybox.
The memory consumption and reliability for extracting large files could be better.
The 7z command line use -bsp1 -bb to force the % progression in a log file called extraction_output.
Then extraction_status is parsed to transfer the extracting progression to installUI.
As the extracting command runs in another shell the file called "extraction_status" will get the result of the 7z command.
@schmurtzm schmurtzm enabled auto-merge June 16, 2023 01:54
@schmurtzm schmurtzm added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit b321c9a Jun 16, 2023
@schmurtzm schmurtzm deleted the unzip_replacement branch June 16, 2023 02:32
@schmurtzm schmurtzm restored the unzip_replacement branch June 18, 2023 15:47
@schmurtzm schmurtzm deleted the unzip_replacement branch June 18, 2023 15:48
@Aemiii91 Aemiii91 mentioned this pull request Jul 4, 2023
Closed
@Aemiii91 Aemiii91 added the bug in onion Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sichroteph Sichroteph Sichroteph approved these changes

Assignees
No one assigned
Labels
bug in onion Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmurtzm @Sichroteph @Aemiii91