FIX: Multiple network time issues #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix UI freeze on network time toggle - Fix uneccesary multiple calls of get_time() - Try second time API before falling back to NTP - Reduce cURL timeout from 120s (default) to 5s
tGecko
changed the title
tGecko
changed the title
3 tasks
Aemiii91
previously approved these changes
Jul 4, 2023
Aemiii91
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UI freeze on network time toggle, multiple get_time calls
Let update_networking.sh run in the background when toggling NTPstate.
This means if it is toggled multiple times, it will also get run multiple times in parallel. In my testing this had no negative effects.
Fix multiple calls of get_time()
get_time() was called a few too many times for multiple reasons, tried to fix them by
examples:
("started time update" is logged when get_time() is run)
Closing tweaks when timezone was changed:
main
fix-ntp-ui-freeze
Toggling NTP when timezone was not changed:
main
fix-ntp-ui-freeze
Toggling NTP when timezone was changed:
main
fix-ntp-ui-freeze
Try second time API before falling back to NTP
As a second fallback before using the really slow ntp, use another API (timeapi.io)
Reduce cURL timeout from 120s (default) to 5s
cURL has a crazy default timeout of 120 seconds, which would lock up the UI completely if the server doesn't respond.
To deal with is, timeout was set to 5 seconds.