FIX: Improved installer #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installation test cases
|
- Note from man: CAUTION: this flag does not do what you think, avoid using it
This was referenced Jul 8, 2023
XK9274
approved these changes
Jul 8, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
… fixes - File size check (#969) ## Problem GLO is currently calculating the chksum of both the current rom and core - this is very slow for PSX. ## Changes * Cksum generation removed from GLO (But GLO still makes half of the cookie, (rom path/core path)) * Cksum generation now added to the host side script but delays mitigated by checking file size for larger files, less accurate but much faster. * Added filesize check to host script (If any of the files are above 25mb we write the file size instead of the cksum) - Cookie label will become [$typesize] instead of [$typechksum] * Added filesize check to join script (If any of the files are above 25mb we match the file size instead of the cksum) * Add proxy scripts to Favourites/Recents/RApp (moved parent scripts to .tmp_update/script/easynetplay) * Aligned log output with host or client * Fixed intermittent issue with wifi re-association. * Replaced "exit" with "cleanup" to attempt to restore the wifi state if we don't actually do a full cycle (we fail somewhere critical) - this will also clear bad network ids from wpa_supp so we don't bloat the file with stale networks. * Improved speeds for both hosting and joining * Fixed logging output and filename * GLO now hides scripts not available to the MM (such as networking) * Fixed host side hanging on exit of retroarch * Script names updated * Clientside now confirms joining ## To-do: - [x] Allow the process to be killed at any point - [ ] ~~Add custom RetroArch config overrides for Easy Netplay~~ Tested on stock config. - [x] Add migration script to remove old romscripts (see #991) ## Tested with: PSX Rearmed -> Digimon world 2 - to validate delay on larger roms TGBDual GB - Balloon kid - to validate we haven't regressed on smaller roms/cores mGBA GBA - Pokemon Leaf (Spectate) to validate we haven't regressed on smaller roms/cores Bubble bobble - NES - FCEUMM - Netplay works flawlessly for 2p on this game We could really do with a progress bar on the rom download/core download screen if PSX ever becomes viable for netplay as the roms are huge. --------- Co-authored-by: XK <[email protected]>
Aemiii91
added
bug in onion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.tmp_updateruntime.shdirectly)runtime.shmiyoofolder needs to be transferred to update OnionLD_LIBRARY_PATH