Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated mumbai with amoy #168

Merged
merged 4 commits into from
Apr 18, 2024
Merged

chore: replace deprecated mumbai with amoy #168

merged 4 commits into from
Apr 18, 2024

Conversation

zixiang2018
Copy link
Contributor

yapyuyou
yapyuyou previously approved these changes Apr 16, 2024
View reviewed changes
superical
superical reviewed Apr 16, 2024
View reviewed changes
foundry.toml Outdated
@@ -22,7 +22,7 @@
mainnet = { key = "${API_KEY_ETHERSCAN}" }
optimism = { key = "${API_KEY_OPTIMISTIC_ETHERSCAN}" }
polygon = { key = "${API_KEY_POLYGONSCAN}" }
mumbai = { key = "${API_KEY_POLYGONSCAN}" }
amoy = { key = "${API_KEY_POLYGONSCAN}" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm... I don't think this is going to work.😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed a fix in 5a56e54 for this.

Other than this, looks good!👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for helping with this part!

@superical
Copy link
Contributor

superical commented Apr 16, 2024 •
edited
Loading

After #170 has been merged, your Test Coverage pre-check error should go away.

I have also changed your PR to chore instead of feat because your changes are only affect the config and probably don't require another release. You may have to remember to change it to chore when merging too in case Github doesn't automatically update the eventual commit message based on the new PR title.

@superical superical changed the title feat: replace deprecated mumbai with amoy chore: replace deprecated mumbai with amoy Apr 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (17bb1d7) to head (c7adb72).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           7        7           
  Lines         114      114           
=======================================
  Hits          113      113           
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

superical
superical approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@superical superical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@zixiang2018 zixiang2018 merged commit 2768ffd into master Apr 18, 2024
9 checks passed
@zixiang2018 zixiang2018 deleted the feat/support-polygon-amoy branch April 18, 2024 02:59
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superical superical superical approved these changes

@yapyuyou yapyuyou yapyuyou left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zixiang2018 @superical @codecov-commenter @yapyuyou