-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine naming of "callbacks" #216
Comments
I believe there are two things to be named here:
|
So we need a solution for 1 (and #161). |
It is relatively easy to replace callback in documentation, but it's still in the process graphs ("callback" property). Depending on the amount of changes we have for the API (looking especially at option 1 in #161 (comment)) we may replace it or not. Would prefer to not change it in the process graphs, but if we work heavily on the API anyway for consistency, then I'd probably also make the naming in the process graph consistent. ToDos:
|
Here again, I think it does not matter much, what it is called in the process graph, as this is not so relevant to the client user. The important thing is, that the client library user, can build graphs with callbacks in an easy manner (again building graphs, without necessarily being aware of the fact, that a graph is created in the background by the client implementation). What has to be clear is, that the user is aware of how the callback portion of the graph is evaluated and applied on the input data. Meaning he needs to know if a function is called e.g. on every pixel or collectively on the whole data-set or flattening/reducing along a specific dimension, e.g. temporal mean, kernel-function in spatial domain, minimum value of all values, or just a specific dimension... For me again it is fine to call this concept differently in each client library/application as long as it something that a typical user of the specific client can relate to conceptually. |
I'd conclude that in the API itself we just call it parametrized process graph (until we plan to go for #161). In the end it is really just a special type of process graph. For the API, that seems the best choice. Clients can the call this however it fits best in their environment/community although the process descriptions will not adapt magically to use this term. Function or process seems to be the preferable options for the process descriptions. As we are always use processes, I guess I'll go with process in the descriptions. Interestingly, we don't call UDFs UDPs ;-) |
In the 3rd year planning concerns were raised that callback (inspired from JS) is not a well-known word in Python and R. We should either call it differently (in R and Python a function called from a function has no specific name, is just called "function") or add a glossary entry.
callback is not very well chosen anyway, because the function is not necessarily called once data is available, but immediately.
The text was updated successfully, but these errors were encountered: