-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirection of POST /services and /jobs #269
Comments
Location is also applicable for HTTP 201, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/201. Is tells the back-end where the new resource can be found. Indeed the examples are a bit misleading. The green area should better say "Mapping" instead of "Examples" and "points to" instead of "redirects to". The intentions was to show which endpoint should point to which resource. I'll fix that. Does that help, @soxofaan ? |
I would certainly avoid "redirect" but the difference between the examples is still confusing:
What is also not that obvious (or explicit) is that this "Location" url should be the "full metadata" endpoint. For example, I think in the VITO backend we return the WMTS base url here instead of the service metadata endpoint, which is wrong if I understand correctly |
Can't you just move all examples to the "Location" header doc e.g. something like:
|
In the green area I am refering to the endpoints as defined in the OpenAPI file, the Location example is as concrete as possible with re-usable templates. So indeed it's meant to point to the metadata. Nevertheless, I'll issue a PR later and let you review. |
… header in `HTTP 201` responses. #269
great, thanks |
…iance Also fix location header of 'POST /services' endpoint (Open-EO/openeo-api#269)
Introduce a `ServiceMetadata` class to wrap service metadata in a container with stronger schema/typing than free form dict. Also fix "Location" header in 'POST /services' response (Open-EO/openeo-api#269): should be service metadata endpoint, not service (base) url.
from current API 1.0 docs about response on
POST /jobs
andPOST /services
:This is a bit confusing:
-- above:
/services/{service_id}
and/jobs/{job_id}
-- below:
https://openeo.org/api/v1.0/resource/123
The text was updated successfully, but these errors were encountered: