Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch job logs when job is not finished or even started #315

Closed
soxofaan opened this issue Jul 14, 2020 · 2 comments · Fixed by #316
Closed

batch job logs when job is not finished or even started #315

soxofaan opened this issue Jul 14, 2020 · 2 comments · Fixed by #316
Milestone

Comments

@soxofaan
Copy link
Member

GET /jobs/{job_id}/logs

It's not specified explicitly how back-end should behave when a batch job is still "created"/"queued".
In VITO backend we currently throw JobNotStarted error, because that seemed fitting, but (D28) validator does not like that.
Should we just return empty list of log entries?

soxofaan added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Jul 14, 2020
@m-mohr
Copy link
Member

m-mohr commented Jul 14, 2020

Logs can be used at all stages of a job, but I see that this part can be a bit misleading:

If requested consecutively while a job is running, it is RECOMMENDED that clients use the offset parameter to get only the entries they have not received yet.

I'll try to improve and issue a PR.

m-mohr added a commit that referenced this issue Jul 14, 2020
@m-mohr m-mohr linked a pull request Jul 14, 2020 that will close this issue
@m-mohr
Copy link
Member

m-mohr commented Jul 14, 2020

see PR #316

m-mohr added a commit that referenced this issue Jul 14, 2020
@m-mohr m-mohr closed this as completed Jul 14, 2020
@m-mohr m-mohr added this to the v1.0.0-final milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants