FileTypeInvalid vs FormatUnsuitable

[soxofaan]

The API defines FileTypeInvalid

openeo-api/errors.json

Lines 162 to 168 in c5a45b4

	"FileTypeInvalid": {
	"description": "File format or file extension is not allowed.",
	"message": "File format {type} not allowed. Allowed file formats: {types}",
	"http": 400,
	"tags": [
	"File Management"
	]

A couple openeo processes however define FormatUnsuitable: load_uploaded_files, load_url, save_result.

I wonder how useful FileTypeInvalid is actually. It's defined in openeo-api, becuase it's part of the file API, but why would certain file extensions or format (which implies inspection of the data) be forbidden in the phase of uploading a file? That seems like a pretty annoying feature of a file API.

If a back-end does not support loading the format at processing time, then it will throw FormatUnsuitable

[m-mohr]

FileTypeInvalid is for the /files endpoints (tag: "File Management"), the others are for specific processes.
I assumed some back-ends may want to restrict what users could upload, but maybe they don't?
Anyway, it doesn't hurt to have the error, no?

[soxofaan]

back-ends may want to restrict what users could upload, but maybe they don't?

that just seems annoying. And users probably will circumvent it anyway (e.g. append .txt or .json extension just to get something uploaded)

Anyway, it doesn't hurt to have the error, no?

Well, its presence tricked me in using the wrong error code in the validation part of load_url 😄