Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: Allow auth code flow and device flow for default clients #411

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Aug 25, 2021

Fixes/Implements #410.

Could someone verify that my understanding of the authorization_code flow is correct and doesn't require a client_secret?

@m-mohr m-mohr added the minor requires a minor-version (x.1.0 for example) label Aug 25, 2021
@m-mohr m-mohr added this to the 1.2.0 milestone Aug 25, 2021
Copy link
Member

@aljacob aljacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Matthias, with we should have the most relevant oidc use cases covered!

@soxofaan
Copy link
Member

Could someone verify that my understanding of the authorization_code flow is correct and doesn't require a client_secret?

from https://www.rfc-editor.org/rfc/rfc6749.html#section-2.3:

The authorization server MAY accept any form of client authentication meeting its security requirements.

if "any form of client auth" also includes "no client auth", then I guess authorization_code without client_secret/PKCE is indeed allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor requires a minor-version (x.1.0 for example)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants