Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_stac: result differs between canonical and unsigned URL #669

Closed
bossie opened this issue Feb 2, 2024 · 1 comment · Fixed by #774
Closed

load_stac: result differs between canonical and unsigned URL #669

bossie opened this issue Feb 2, 2024 · 1 comment · Fixed by #774
Assignees
@bossie
Labels
bug

Comments

@bossie
Copy link
Collaborator

bossie commented Feb 2, 2024

Output assets have different CRS and resolution. Why?

On https://openeo-dev.vito.be:

Original job: j-240202454fdf4f3b9d8b998310094c30
Job with load_stac of canonical URL of j-240202454fdf4f3b9d8b998310094c30 results: j-2402026b9f994966b025e6a37d29faca
Job with load_stac of unsigned URL of j-240202454fdf4f3b9d8b998310094c30 results: j-240202074ff5443188df872394c03c45
@bossie
Copy link
Collaborator Author

bossie commented Feb 5, 2024

Theory: asset metadata i.e. proj: is taken into account when loading from a canonical URL but not in the case of an unsigned URL (which bypasses HTTP).

TBC.

bossie added a commit to Open-EO/openeo-geopyspark-driver-testdata that referenced this issue May 7, 2024
@bossie
add test files
64440c9 
Open-EO/openeo-geopyspark-driver#669
bossie added a commit that referenced this issue May 7, 2024
@bossie
add test #669
b8b4337
@bossie bossie mentioned this issue May 7, 2024
Merged
@bossie bossie linked a pull request May 7, 2024 that will close this issue
fix load_stac from unsigned job URL #774
Merged
bossie added a commit that referenced this issue May 7, 2024
@bossie
fixup! add test #669
56fbc50
bossie added a commit that referenced this issue May 7, 2024
@bossie
load_stac: respect proj: metadata in batch job results #669
e528472
bossie added a commit that referenced this issue May 8, 2024
@bossie
streamline test #669
f0edcad
bossie added a commit that referenced this issue May 8, 2024
@bossie
no need to mock URLs to own batch job results #669
c9ba36b
bossie added a commit that referenced this issue May 8, 2024
@bossie
update CHANGELOG #669
b7dc373
bossie added a commit that referenced this issue May 8, 2024
@bossie
fix output assets of load_stac from unsigned job results URL #669
a934b4b 
CRS and resolution now match those of the signed job results URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bossie bossie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix load_stac from unsigned job URL Open-EO/openeo-geopyspark-driver
2 participants
@bossie @JeroenVerstraelen