Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_by_feature: use feature property to name output items/assets #722

Closed
jdries opened this issue Mar 13, 2024 · 5 comments
Closed

sample_by_feature: use feature property to name output items/assets #722

jdries opened this issue Mar 13, 2024 · 5 comments
Assignees

Comments

@jdries
Copy link
Contributor

jdries commented Mar 13, 2024

No description provided.

@jdries
Copy link
Contributor Author

jdries commented Mar 14, 2024

@VincentVerelst on cdse staging, can you try setting feature_id_property in your format options? It needs to be set to a property of your vector data, like 'id' or something else that's unique.

@VincentVerelst
Copy link

It seems that the item ID's are still just the default ones (openEO_0.nc, openEO_1.nc, etc.).
I've labelled the ID's in my geometry explicitly as test_id_0, test_id_1, etc. and used the following code:

sampled_features = s2.filter_spatial(geometry)
job = sampled_features.execute_batch(
    title="Test feature property to name output files in sample_by_feature",
    out_format="netCDF",
    sample_by_feature=True,
    feature_id_property='id')

Batch job ID: j-240314c4cc37439caad5ce544eef3f89
Run on CDSE-staging

@jdries
Copy link
Contributor Author

jdries commented Mar 18, 2024

@VincentVerelst I had a look, I think it currently only works when you have a 'real' vector cube in filter spatial, rather than specifying geojson inline.
We should also fix this, but it could be that it actually works already when gfmap loads the geometry from geoparquet.

jdries added a commit to Open-EO/openeo-python-driver that referenced this issue Mar 18, 2024
@jdries
Copy link
Contributor Author

jdries commented Mar 18, 2024

Also made a commit to try and make it work for inline FeatureCollection, still needs to go through pipelines.

jdries added a commit to Open-EO/openeo-python-driver that referenced this issue Mar 18, 2024
@JeroenVerstraelen
Copy link
Contributor

Vincent confirmed that this works. (Geoparquet and geojson).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants