Creo missing products #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileSonneveld
force-pushed
the
creo_missing
branch
from
1111c6d
to
b9183d5
Compare
soxofaan
reviewed
Nov 14, 2023
| @@ -75,6 +75,13 @@ def set_all(properties: dict): | |||
| set_all(orig_properties) | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def catalog(vault): | |||
There was a problem hiding this comment.
why is this fixture added? It doesn't seem to be used
| from openeogeotrellis.testing import random_name, KazooClientMock, config_overrides | ||
| from openeogeotrellis.utils import ( | ||
| UtcNowClock, | ||
| drop_empty_from_aggregate_polygon_result, | ||
| get_jvm, | ||
| is_package_available, | ||
| ) | ||
| from openeogeotrellis.vault import OAuthCredentials | ||
| from .data import get_test_data_file | ||
| from tests.data import get_test_data_file |
There was a problem hiding this comment.
I'm not sure this is an improvement over the original from .data import get_test_data_file (which is also not ideal by the way). This import makes it look like there is some top-level tests package in the venv while the relative import makes it more clear it is just from a sibling file.
Is there a particular reason you changed this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.