Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickfix: avoid hanging ZK get_job calls #632 #639

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

bossie
Copy link
Collaborator

@bossie bossie commented Jan 15, 2024

Context: calls to get a batch job from ZK seem to hang and occupy Gunicorn threads, blocking other requests.

The quickfix is to favor EJR and thus relieve ZK in this case.

@bossie bossie linked an issue Jan 15, 2024 that may be closed by this pull request
@bossie bossie marked this pull request as ready for review January 15, 2024 14:27
Copy link
Contributor

@jdries jdries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bossie bossie merged commit 4b4fe78 into master Jan 16, 2024
1 check failed
@bossie bossie deleted the zk_get_job_hangs branch January 16, 2024 08:56
@bossie bossie mentioned this pull request Jan 16, 2024
@bossie
Copy link
Collaborator Author

bossie commented Jan 18, 2024

This was ultimately rolled back because it messed up the batch job result metadata (in particular, its spatial and temporal extent). #635 should fix this in a more general way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phase out ZkJobRegistry
2 participants