Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerical errors when calculating SD? #225

Closed
EmileSonneveld opened this issue Nov 8, 2023 · 5 comments · Fixed by #245
Closed

Numerical errors when calculating SD? #225

EmileSonneveld opened this issue Nov 8, 2023 · 5 comments · Fixed by #245
Assignees
@jdries
Labels
bug Something isn't working

Comments

@EmileSonneveld
Copy link
Contributor

Looks like some floating point errors, or integer overflow.

.aggregate_temporal(intervals=temporal_extent, labels=[temporal_extent[0]], reducer="sd", dimension="t")

job_id: j-23110872a30f419fb4ace82d03c2cbc8
image
image
@soxofaan
Copy link
Member

soxofaan commented Nov 9, 2023

as discussed: check if doing (cube * 1.0).aggregate_temporal(... instead of cube.aggregate_temporal(... can be used as workaround

@EmileSonneveld
Copy link
Contributor Author

That indeed works. Recalculation here:
image

I still feel this might be a nice thing to fix, as the result values are around the same range as the original values and the result may be of the same cellType

@soxofaan
Copy link
Member

soxofaan commented Nov 9, 2023

sure, this has to be fixed, but the good thing is that there is a simple workaround for now

@soxofaan soxofaan added the bug Something isn't working label Nov 9, 2023
@EmileSonneveld EmileSonneveld mentioned this issue Nov 13, 2023
Closed
jdries added a commit that referenced this issue Dec 14, 2023
@jdries
reduce_dimension: support celltype conversion
57bc8ba 
Open-EO/openeo-geopyspark-driver#581
#225
jdries added a commit that referenced this issue Dec 14, 2023
@jdries
aggregate_temporal: support celltype conversion
6d8a11b 
Open-EO/openeo-geopyspark-driver#581
#225
@jdries jdries self-assigned this Dec 14, 2023
@jdries
Copy link
Contributor

jdries commented Dec 14, 2023

may be fixed as side effect of other celltype issues

@jdries jdries linked a pull request Jan 3, 2024 that will close this issue
celltype conversion in every xy function #245
Merged
jdries added a commit that referenced this issue Jan 8, 2024
@jdries
expose new method, to prepare for celltype conversion
c7404f2 
Open-EO/openeo-geopyspark-driver#581
#225
jdries added a commit that referenced this issue Jan 30, 2024
@jdries
trying to preserve user defined nodata in case of floating point
830d1f3 
Open-EO/openeo-geopyspark-driver#581
#225
@jdries
Copy link
Contributor

jdries commented Feb 1, 2024

@EmileSonneveld should be fixed on dev instances. Please try again and reopen if necessary.

@jdries jdries closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdries jdries

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

celltype conversion in every xy function Open-EO/openeo-geotrellis-extensions
3 participants
@soxofaan @EmileSonneveld @jdries