-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image-shifts through bbox, filter_spatial, or spatial_extent #69
Comments
At 16Dec my findings remain: Data example of two extents, where the center-of-pixel of a 1km top-left pixel = 25.000000, -15.383929 A. Use exact corner-of-corners of required pixels: {'east': 33.29910714314813, B. Use with half a 333m pixel (0.5/336) extra window-size on all sides: Then the Corner-of-Corner of the top-left-pixel becomes: and the Center-of-Pixel of the top-left-pixel becomes: |
Also happens with worldcover. Proposed solution: if datacube extension has the extent set, and the target crs is the same as source crs, we can try to align the user-provided extent to the one of the dataset. |
…xel shifts (depends on having proper collection metadata) Open-EO/openeo-geotrellis-extensions#69
weird, seems like this one got closed automaticaly by a github bot?! |
…sources should be pre-aligned to layout
…the incoming extent, reduces special cases
* apply global_bounds also when not in utm projection * do not apply rounding to resolution as a general rule, stick to globalbounds which is assumed to be rounded already if needed * also skip resampling for layers that are not utm, all raster sources should be pre-aligned to layout * align extent to layout before loading data * further apply principle of always aligning raster sources to the incoming extent, reduces special cases * update agera5 and dem tests, output has improved thanks to changes
I now fixed a lot of metadata to enable the feature that should improve the alignment, will appear on openeo-dev soon. Closing this one already, to reopen if still seeing the issues in a few days. |
When applying through OPENEO bbox, filter_spatial, or spatial_extent, the most top-left selected pixel (of 1km and 300m imagery!) shifts to the edge of the specified box or defined spacial extent. When extracting using OPENEO an area-of-interest, selected pixcels MUST however actually remain exactly where they were originally placed. When defining a boundary that coincides with pixel-centroids, that always leads to half a pixel shift while the user cannot predict what the first top-left pixel will be (there are 4 candidates!!). See below an example of a half-pixel (500m!!!) shift:
The text was updated successfully, but these errors were encountered: