Encapsulate "driver implementation" functions #8

soxofaan · 2019-07-16T13:42:48Z

openeo-python-driver allows a plugable "DRIVER_IMPLEMENTATION_PACKAGE", but does this quite rudimentary at the moment. E.g:

i = importlib.import_module(os.getenv('DRIVER_IMPLEMENTATION_PACKAGE', "dummy_impl"))
getImageCollection = i.getImageCollection
get_layers = i.get_layers
try:
    create_process_visitor = i.create_process_visitor
except AttributeError as e:
    create_process_visitor = None
create_batch_job = i.create_batch_job
run_batch_job = i.run_batch_job
get_batch_job_info = i.get_batch_job_info
get_batch_job_result_filenames = i.get_batch_job_result_filenames

( https://github.com/Open-EO/openeo-python-driver/blob/314023137/openeo_driver/ProcessGraphDeserializer.py#L67 )

This approach of copy-pasting toplevel functions scales quite ugly and ruins code intelligence in your editor/IDE.

It would be cleaner to encapsulate this intermediate "API" e.g. as (abstract) classes that backends have to implement. This is more explicit API-wise, more self documenting and allows your IDE to be more helpful.

The text was updated successfully, but these errors were encountered:

…art of the openEO API

… class - add `CollectionCatalog`: a basic catalog implementation to manage collection metadata and entrypoint for the `load_collection` process - replaces `get_layer`, `get_layers` and `getImageCollection` globals

…ntation`

…O#12, Open-EO/openeo-python-driver#8)

Extract better decoupled layer catalog (EP-3079/#8)

…pen-EO#13, Open-EO#17, Open-EO#8)

…er#8)

…fy API compliance Introduce a `BatchJobMetadata` class to wrap batch job metadata in a container with stronger schema/typing that a free form dict

…roservice"

…entation`

…ation`

bump minor level of version to signal substantial refactor of "backend implementation" handling in openeo_driver (Open-EO#8, Open-EO#34, EP-3352)

- it's cleaner to have a single toplevel package - also add script to run flask app with dummy backend

…bs "microservice"

…fy API compliance Introduce a `BatchJobMetadata` class to wrap batch job metadata in a container with stronger schema/typing that a free form dict

…roservice"

…entation`

…ation`

bump minor level of version to signal substantial refactor of "backend implementation" handling in openeo_driver (Open-EO#8, Open-EO#34, EP-3352)

- it's cleaner to have a single toplevel package - also add script to run flask app with dummy backend

soxofaan · 2020-04-21T07:35:25Z

done (as part of #34)

soxofaan mentioned this issue Jul 16, 2019

Avoid heavy __init__.py Open-EO/openeo-geopyspark-driver#12

Closed

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Jul 17, 2019

Issue Open-EO#8 and EP-2461 "microservicify" the secondary services p…

79dcf85

…art of the openEO API

This was referenced Jul 17, 2019

Refactor secondary service management and allow service deletion (python-driver part) #10

Merged

Refactor secondary service management and allow service deletion (geopyspark-driver part) Open-EO/openeo-geopyspark-driver#13

Merged

soxofaan mentioned this issue Sep 4, 2019

Encapsulate "driver implementation" functions Open-EO/openeo-geopyspark-driver#18

Closed

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Sep 18, 2019

Issue Open-EO#8 move "health_check" function to `OpenEoBackendImpleme…

a6db90e

…ntation`

soxofaan added a commit to soxofaan/openeo-geopyspark-driver that referenced this issue Sep 18, 2019

move "health_check" function to OpenEoBackendImplementation (Open-E…

5d2fabb

…O#12, Open-EO/openeo-python-driver#8)

soxofaan mentioned this issue Sep 18, 2019

Extract better decoupled layer catalog (EP-3079/#8) #20

Merged

jdries added a commit that referenced this issue Sep 18, 2019

Merge pull request #20 from soxofaan/EP-3079-layercatalog

03944bf

Extract better decoupled layer catalog (EP-3079/#8)

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Oct 15, 2019

Move output formats listing to OpenEoBackendImplementation (related: O…

8af4e22

…pen-EO#13, Open-EO#17, Open-EO#8)

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Nov 19, 2019

Issue Open-EO#8: refactor batch job management

9fd72e5

soxofaan added a commit to soxofaan/openeo-geopyspark-driver that referenced this issue Nov 19, 2019

implement BatchJobManagement microservice (Open-EO/openeo-python-driv…

12fdc76

…er#8)

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 16, 2020

Issue Open-EO#8 move additional batch job endpoints to BatchJobs "mic…

408fee3

…roservice"

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 16, 2020

Issue Open-EO#8 move create_process_visitor to `OpenEoBackendImplem…

7db8107

…entation`

soxofaan mentioned this issue Apr 17, 2020

avoid DRIVER_IMPLEMENTATION_PACKAGE #36

Closed

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 17, 2020

Issue Open-EO#8 move summarize_exception to `OpenEoBackendImplement…

780ee57

…ation`

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 17, 2020

Issue Open-EO#8 encapsulate get_backend_implementation better

bc4d1ac

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 17, 2020

_version.py: bump to alpha version 0.2.0a1

18f2570

bump minor level of version to signal substantial refactor of "backend implementation" handling in openeo_driver (Open-EO#8, Open-EO#34, EP-3352)

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 17, 2020

Issue Open-EO#8 move "dummy" package inside openeo_driver

b7dca18

- it's cleaner to have a single toplevel package - also add script to run flask app with dummy backend

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 17, 2020

fixup! Issue Open-EO#8 move additional batch job endpoints to BatchJo…

0385dbd

…bs "microservice"

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 20, 2020

Issue Open-EO#8 move additional batch job endpoints to BatchJobs "mic…

4b57dd3

…roservice"

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 20, 2020

Issue Open-EO#8 move create_process_visitor to `OpenEoBackendImplem…

0d6991c

…entation`

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 20, 2020

Issue Open-EO#8 move summarize_exception to `OpenEoBackendImplement…

e6785fa

…ation`

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 20, 2020

Issue Open-EO#8 encapsulate get_backend_implementation better

40e0f0e

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 20, 2020

_version.py: bump to alpha version 0.2.0a1

6dec793

bump minor level of version to signal substantial refactor of "backend implementation" handling in openeo_driver (Open-EO#8, Open-EO#34, EP-3352)

soxofaan added a commit to soxofaan/openeo-python-driver that referenced this issue Apr 20, 2020

Issue Open-EO#8 move "dummy" package inside openeo_driver

4d90498

- it's cleaner to have a single toplevel package - also add script to run flask app with dummy backend

soxofaan closed this as completed Apr 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encapsulate "driver implementation" functions #8

Encapsulate "driver implementation" functions #8

soxofaan commented Jul 16, 2019

soxofaan commented Apr 21, 2020

Encapsulate "driver implementation" functions #8

Encapsulate "driver implementation" functions #8

Comments

soxofaan commented Jul 16, 2019

soxofaan commented Apr 21, 2020