Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #215 Fix: report correct job status in _list_job_results when p… #224

Merged

Conversation

JohanKJSchreurs
Copy link
Contributor

Issue #215 Fix: report correct job status in _list_job_results when partial=true

This PR corrects the reported job status for some cases in the context of Open-EO/openeo-geopyspark-driver#489, as noted by @bossie, here: #215 (comment) .

  • if partial and job error/canceled -> openeo:status running (expected: error/canceled)
  • if partial and job finished -> no openeo:status (expected: finished)
  • if not partial and job error/canceled -> JobNotFinishedException; after some contemplating I believe this is still OK as the back-end is not required to return intermediate results.

Solution in brief:

Basically we should report the actual job status when partial is true, and also include openeo:status when the job is finished.

  • When partial is false and the jobs is not finished, do the same as before: raise JobNotFinishedException.

@JohanKJSchreurs JohanKJSchreurs marked this pull request as ready for review September 8, 2023 11:16
Copy link
Collaborator

@bossie bossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added remarks inline.

openeo_driver/views.py Outdated Show resolved Hide resolved
openeo_driver/views.py Show resolved Hide resolved
Copy link
Collaborator

@bossie bossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@bossie bossie merged commit 1de3faa into master Sep 29, 2023
@bossie bossie deleted the issue215_part2-improve-reported-job-status-for-partial-results branch September 29, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants