To do fixes #1818 #1974

nilupulmanodya · 2023-08-31T08:15:56Z

Purpose of PR:
Fix To do fixes of previous PR #1818

Fixes #
#1818 (comment)
#1818 (review)
#1818 (comment)
#1818 (comment)
#1818 (review)

Does this PR introduce a breaking change?
No

Does this PR results in some Documentation changes?
yes. Fix typos of conf_sso_test_msscolab.rst

Checklist:

Bug fix. Fixes #
New feature (Non-API breaking changes that adds functionality)
PR Title follows the convention of <type>: <subject>
Commit has unit tests

ReimarBauer · 2023-08-31T09:02:51Z

Hi @nilupulmanodya welcome back.

nilupulmanodya · 2023-08-31T11:29:50Z

Hi @ReimarBauer.. Thanks.. It's good to be back

docs/conf_sso_test_msscolab.rst

mslib/idp/idp_conf.py

docs/conf_sso_test_msscolab.rst

mslib/idp/idp.py

ReimarBauer

see comments

.gitignore

msidp/idp.py

mslib/mscolab/server.py

.gitignore

mslib/utils/mssautoplot.py

docs/conf_sso_test_msscolab.rst

ReimarBauer · 2023-09-18T08:51:31Z

steps I did.

I installed boa into my base environment.

then

cd localbuild

boa convert meta.yaml > recipe.yaml
# I changed alpha to alpha2 in recipe.yaml, to get definitily a new build version name
boa build .
mamba create -n alpha2_env
mamba activate alpha2_env
mamba install mss --use-local
mamba list mss
# packages in environment at /home/reimar/mambaforge/envs/alpha2_env:
#
# Name                    Version                   Build  Channel
mss                       alpha2          py310h8e7c8fa_1000    local

ReimarBauer

Thx, tried it with a build by boa :)

docs/conf_sso_test_msscolab.rst

matrss

I left some comments.

matrss · 2023-09-21T13:57:15Z

docs/conf_sso_test_msscolab.rst

 * Login with identity provider through Qt Client application.
-* To log in to the mscolab server through the identity provider, you can use the credentials specified in the ``PASSWD`` section of the ``MSS/mslib/idp/idp.py`` file. Look for the relevant section in the file to find the necessary login credentials.
+* To log in to the mscolab server through the identity provider, you can use the credentials specified in the ``PASSWD`` section of the ``MSS/mslib/msidp/idp.py`` file. Look for the relevant section in the file to find the necessary login credentials.


So, what is our intended use case for this IdP? I am still not sure I have understood it. Right now we have it under mslib/ and expose entrypoints to it in a way that suggests we want to use this in production and expose this functionality to other admins running a mscolab instance. On the other hand, in this line we point to some file in the source code to get credentials for one of the predefined accounts. That sounds more like testing. For production we would need some kind of proper user management, but I think building an entire production-grade IdP is out-of-scope for us.

I am still of the opinion that we should move everything related to setting up and running this IdP below tests/, make the documentation intended for developers only and not expose this to the end-users of MSS. We can then use this IdP in the test suite to have something easy to setup to test against. To benefit from the SSO feature we will hook this up to an externally managed IdP anyway (Helmholtz AAI, or whatever SAML IdP someone may want to connect to) and have no say in what is running on their side.

This comment isn't a blocker functionality-wise though, so we can merge this PR and address this later.

docs/conf_sso_test_msscolab.rst

* remove inputs from conditions (#1808) * Setup sp and idp for the sso (#1809) * configure sp and idp * update meta.yml remove cherypy * fixes previous * update notice * update readme * regroup idp_uwsgi * regroup app.py * regroup, change wsgi server to flask * Update conf_sp_idp/README.md Co-authored-by: Matthias Riße <[email protected]> * hide secrets by config * update copy-paste-able command for creating keys and certificates * Update README.md * correct copyright lines * remove make_metadata.py file and update doc with new flow * remove idp.xml file * remove condition libxmlsec1 * Update conf_sp_idp/sp/app/conf.py Co-authored-by: Matthias Riße <[email protected]> * Update conf_sp_idp/idp/idp.py Co-authored-by: Matthias Riße <[email protected]> * remove generate_metadatascript * remove hardcoded path * recorrect copyrights --------- Co-authored-by: Matthias Riße <[email protected]> * Split conf sp idp (#1811) * split sp and idp * generate doc * remove prints idp.py * update comeponents.rst * UI changes in Qt for SSO (#1813) * ui changes in qt for sso * fixes qt UI implementation * get idp_enabled response from server * update tests for test_hello * update test utils * Update mslib/msui/mscolab.py Co-authored-by: Matthias Riße <[email protected]> * fix typo * move downed idp_enabled exception * increase height ui_mscolab_connect_dialog * resolve comments --------- Co-authored-by: Matthias Riße <[email protected]> * web browser implementation (#1814) * web browser implementation * update gitgnore * resolve comments * update docstring * Configure mscolab for sso (#1818) * db modeling * add users into id[ * backend yaml implementation * set server conf * config server for sso * qt ui implmentation * backend html templates implementation * update testcases * config qt client app * update gitignore * set yaml endpoints * update docs * update test utill, and fix error * fix test utils * remove disabled pylint * add libxmlsec1 into dep * set IDP ENabled false * Update mslib/mscolab/server.py Co-authored-by: Matthias Riße <[email protected]> * recorrect commit * update db modeling with authentication_backend for multiple idps * update conf for the multiple idps * template implementation * msui update redirect url for multiple idps * saml update for multiple idps * update mscolab server for multiple idps * update doc for multiple idps * automate CERTs generation and paths * update doc * correct typo in doc * update doc * fix typos update gitignore * fix config idp_conf * update gitignore * set one time token access * add params for cert creation * set idp token for one time validation * fix unnnescessary debug * remove duplicate imports * Update mslib/mscolab/mscolab.py Co-authored-by: Matthias Riße <[email protected]> * automate saml yaml file and improve error handling * rename IDP_ENABLED to USE_SAML2 * update error template * update doc * add todo idp_wsgi * update db models * recorrect doc * add todo refactors --------- Co-authored-by: Matthias Riße <[email protected]> * To do fixes #1818 (#1974) * remove global var * remove idp.subjects file dirs * remove relaystste, rndstr and use secrets * remove shell=True * correct typos * fix group order * enable flake8 for GSOC2023-NilupulManodya * fix lint * fix lint * fixes comments * resolve comments * fix comments * update doc * improve code for multiple Idps * conf routes for multiple conf * remove uncessary .yaml * update cmd metadata * update conf * update saml handler for multiple idps * pinning of xmlschema * pin werkzeug * disable pytests for todo refactor * disbale whole file gsoc_testing * fix conf * resolve comments * resolve comments * manual conflict resolve ui_mscolab_connect_dialog.ui file * resolve flake8 * set SSL certificate verification enablement (#2062) * ssl verification enablement for SSO * add hint * Remove testing SP (#2066) * remove testing sp * remove documentation auth_client_sp * Create documentation for SSO integration through SAML (#2064) * create documentation sso integration * added into makefile components * change dir images * resolve comments, add sample files * resolve comments * change cookies dir of web browser (#2063) * change cookies dir of web browser * Update mslib/msui/msui_web_browser.py Co-authored-by: Matthias Riße <[email protected]> --------- Co-authored-by: Matthias Riße <[email protected]> * improve accessibility saml2 urls (#2068) * improve accessibility saml2 urls * resolve comments --------- Co-authored-by: Nilupul Manodya <[email protected]> Co-authored-by: Matthias Riße <[email protected]> Co-authored-by: Matthias Riße <[email protected]> Co-authored-by: nilupulmanodya <[email protected]>

nilupulmanodya added 5 commits August 31, 2023 11:04

remove global var

6385085

remove idp.subjects file dirs

9b4a35b

remove relaystste, rndstr and use secrets

0858ee8

remove shell=True

ddfa1a1

correct typos

b7149ba

nilupulmanodya added 4 commits September 2, 2023 09:19

fix group order

ddfca4a

enable flake8 for GSOC2023-NilupulManodya

d246278

fix lint

f5b235d

fix lint

0cd8c68

nilupulmanodya marked this pull request as ready for review September 2, 2023 05:40

ReimarBauer reviewed Sep 4, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

ReimarBauer reviewed Sep 4, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

ReimarBauer reviewed Sep 4, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

ReimarBauer reviewed Sep 4, 2023

View reviewed changes

mslib/idp/idp_conf.py Show resolved Hide resolved

ReimarBauer reviewed Sep 4, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

ReimarBauer reviewed Sep 4, 2023

View reviewed changes

mslib/idp/idp.py Outdated Show resolved Hide resolved

ReimarBauer requested changes Sep 4, 2023

View reviewed changes

fixes comments

3cb6cfc

nilupulmanodya requested a review from ReimarBauer September 12, 2023 15:26

matrss reviewed Sep 14, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

msidp/idp.py Outdated Show resolved Hide resolved

mslib/mscolab/server.py Show resolved Hide resolved

resolve comments

f26afb9

nilupulmanodya mentioned this pull request Sep 17, 2023

SSL verification enablement for mscolab #2039

Closed

4 tasks

ReimarBauer reviewed Sep 18, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

ReimarBauer reviewed Sep 18, 2023

View reviewed changes

mslib/utils/mssautoplot.py Show resolved Hide resolved

ReimarBauer reviewed Sep 18, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

ReimarBauer reviewed Sep 18, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

ReimarBauer reviewed Sep 18, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Show resolved Hide resolved

fix comments

a7ffea6

nilupulmanodya requested a review from ReimarBauer September 20, 2023 13:09

ReimarBauer approved these changes Sep 21, 2023

View reviewed changes

ReimarBauer reviewed Sep 21, 2023

View reviewed changes

docs/conf_sso_test_msscolab.rst Outdated Show resolved Hide resolved

matrss reviewed Sep 21, 2023

View reviewed changes

update doc

08a4f9a

ReimarBauer merged commit 529e7f6 into Open-MSS:GSOC2023-NilupulManodya Sep 24, 2023
3 checks passed

nilupulmanodya mentioned this pull request Sep 25, 2023

Configure mscolab for sso #1818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

To do fixes #1818 #1974

To do fixes #1818 #1974

nilupulmanodya commented Aug 31, 2023

ReimarBauer commented Aug 31, 2023

nilupulmanodya commented Aug 31, 2023

ReimarBauer left a comment

ReimarBauer commented Sep 18, 2023 •

edited

Loading

ReimarBauer left a comment

matrss left a comment

matrss Sep 21, 2023

To do fixes #1818 #1974

To do fixes #1818 #1974

Conversation

nilupulmanodya commented Aug 31, 2023

ReimarBauer commented Aug 31, 2023

nilupulmanodya commented Aug 31, 2023

ReimarBauer left a comment

Choose a reason for hiding this comment

ReimarBauer commented Sep 18, 2023 • edited Loading

ReimarBauer left a comment

Choose a reason for hiding this comment

matrss left a comment

Choose a reason for hiding this comment

matrss Sep 21, 2023

Choose a reason for hiding this comment

ReimarBauer commented Sep 18, 2023 •

edited

Loading